[compiler-rt] r375162 - [Builtins] Downgrade duplicate source file warning from a fatal error to a warning.

Dan Liew via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 17 13:14:04 PDT 2019


Author: delcypher
Date: Thu Oct 17 13:14:04 2019
New Revision: 375162

URL: http://llvm.org/viewvc/llvm-project?rev=375162&view=rev
Log:
[Builtins] Downgrade duplicate source file warning from a fatal error to a warning.

This is a follow up to r375150 to unbreak the `clang-ppc64be-linux` bot.
The commit caused running the tests to fail due to

```
llvm-lit:
/home/buildbots/ppc64be-clang-multistage-test/clang-ppc64be-multistage/llvm/projects/compiler-rt/test/builtins/Unit/lit.cfg.py:116:
fatal: builtins_source_features contains duplicates:
['librt_has_divtc3']
```

This commit should be reverted once the build system bug for powerpc is
fixed.

Modified:
    compiler-rt/trunk/test/builtins/Unit/lit.cfg.py

Modified: compiler-rt/trunk/test/builtins/Unit/lit.cfg.py
URL: http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/test/builtins/Unit/lit.cfg.py?rev=375162&r1=375161&r2=375162&view=diff
==============================================================================
--- compiler-rt/trunk/test/builtins/Unit/lit.cfg.py (original)
+++ compiler-rt/trunk/test/builtins/Unit/lit.cfg.py Thu Oct 17 13:14:04 2019
@@ -111,7 +111,9 @@ for builtin_source_feature in builtins_s
     builtins_source_feature_duplicates.append(builtin_source_feature)
 
 if len(builtins_source_feature_duplicates) > 0:
-  lit_config.fatal(
+  # FIXME(dliew): There's a bug in the build system for powerpc where two definitions of the same
+  # function are present in the library. So just downgrade this to a warning until this is fixed.
+  lit_config.warning(
     'builtins_source_features contains duplicates: {}'.format(
       builtins_source_feature_duplicates)
   )




More information about the llvm-commits mailing list