[PATCH] D68975: [LLD] [COFF] Try to report source locations for duplicate symbols

[Nico Weber via Phabricator via llvm-commits]

thakis added a comment.

In D68975#1712187 <https://reviews.llvm.org/D68975#1712187>, @ruiu wrote:

> Nico, are you happy with this change?


The output looks fine from what's in the test expectations. To know how it feels in practice I think it's best to land this and use it for a bit.

Code-wise, it's quite a bit of code for dwarf debug info which isn't really used all that much, but meh. I kind of feel like it might possibly make sense to move all the CoffMingw bits into a separate lld/ directory instead of having it in lld/COFF since it's lots of special purpose code. But that's not my call :)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68975/new/

https://reviews.llvm.org/D68975