[PATCH] D68917: [Demangle] Add a few more options to the microsoft demangler

Nico Weber via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 17 12:26:20 PDT 2019


thakis added a comment.

This is cool, thanks!

Note that there are a 3 or so places where the demangler also hardcodes OF_Default. One patch that I have sitting around locally fixes one of them (https://gist.github.com/nico/8f219c64c9269c1f8c6657c46f3e8644 -- feel free to take that one over; I wrote it for something else that I couldn't yet prove is actually a problem; from the test script at the bottom you can probably figure out what it was :)). As-is, these options are ignored for these cases (cached types in templates, parent scopes of locally numbered scopes, and something else). It's possible that these contexts are unaffected by these options, but I figured I'd mention it, in case you want to check.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68917/new/

https://reviews.llvm.org/D68917





More information about the llvm-commits mailing list