[PATCH] D64817: [CMake] Fix LLVM build non-determinism on RHEL

[Amy Kwan via Phabricator via llvm-commits]

amyk marked an inline comment as done.
amyk added inline comments.


================
Comment at: llvm/cmake/modules/HandleLLVMOptions.cmake:149-150
+if(${CMAKE_SYSTEM_NAME} MATCHES "Linux")
+  # RHEL has ar and ranlib being non-deterministic by default. The D flag forces determinism,
+  # however only GNU version of ar and ranlib have this option
+  execute_process(COMMAND ${CMAKE_AR} rD t.a
----------------
tstellar wrote:
> Can you make this comment more specific about which versions of RHEL and also ar and randlib this is intended for?  If we ever drop support for these older tools, this would make it easier to identify and remove this section. 
> 
> Otherwise, LGTM.
Thanks for pointing that out. The comment has been updated. 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64817/new/

https://reviews.llvm.org/D64817