[PATCH] D69076: [cmake] Pass external project source directories to sub-configures

Shoaib Meenai via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 17 12:08:09 PDT 2019


smeenai added a comment.

In D69076#1713418 <https://reviews.llvm.org/D69076#1713418>, @compnerd wrote:

> I’m not sure that this is the best direction long term.  This is specific to the LLVM build, the runtimes builds do not take these parameters, and they are the primary things we’re trying to cross compile with this infrastructure.  But the monorepo makes this more complicated and makes the configure the same, so, yes, I suppose this needs to be preserved.  *sigh*


I believe the runtimes builds use the ExternalProject infrastructure. The CrossCompile infrastructure is used for e.g. building native tablegen binaries when you're cross-compiling LLVM.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69076/new/

https://reviews.llvm.org/D69076





More information about the llvm-commits mailing list