[PATCH] D69126: [Object] Fix the return type of getOffset/getSize

Shoaib Meenai via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 17 11:40:16 PDT 2019


smeenai accepted this revision.
smeenai added a comment.

This makes sense, but I'm wondering if we need to adjust any call sites to assert that a result they compute that needs to be 32 bits actually fits in 32 bits. Those locations would have just been silently overflowing before though, so this at least gives them the ability to detect that overflow.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69126/new/

https://reviews.llvm.org/D69126





More information about the llvm-commits mailing list