[PATCH] D69099: [TargetLowering][DAGCombine][MSP430] Shift Amount Threshold in DAGCombine (Baseline Tests)

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 17 07:12:06 PDT 2019


spatel accepted this revision.
spatel added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: llvm/test/CodeGen/MSP430/shift-amount-threshold.ll:6
+
+define dso_local i16 @testSimplifySetCC_0(i16 %a) {
+; CHECK-LABEL: testSimplifySetCC_0:
----------------
joanlluch wrote:
> spatel wrote:
> > Here and below: remove unnecessary "dso_local"
> I'm unsure about what dsl_local means, this was generated by clang, but I'll remove it if not necessary.
For our needs within this file, I think it's just noise:
http://llvm.org/docs/LangRef.html#runtime-preemption-specifiers


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69099/new/

https://reviews.llvm.org/D69099





More information about the llvm-commits mailing list