[PATCH] D69099: [TargetLowering][DAGCombine][MSP430] Shift Amount Threshold in DAGCombine (Baseline Tests)

[Sanjay Patel via Phabricator via llvm-commits]

spatel added inline comments.


================
Comment at: llvm/test/CodeGen/MSP430/shift-amount-threshold.ll:3-4
+; RUN: llc < %s | FileCheck %s
+target datalayout = "e-m:e-p:16:16-i32:16-i64:16-f32:16-f64:16-a:8-n8:16-S16"
+target triple = "msp430"
+
----------------
I'm not sure if there's a difference, but I usually specify the triple in the RUN line, and I don't explicitly set a datalayout.


================
Comment at: llvm/test/CodeGen/MSP430/shift-amount-threshold.ll:6
+
+define dso_local i16 @testSimplifySetCC_0(i16 %a) {
+; CHECK-LABEL: testSimplifySetCC_0:
----------------
Here and below: remove unnecessary "dso_local"


================
Comment at: llvm/test/CodeGen/MSP430/shift-amount-threshold.ll:160
+
+define dso_local i16 @testShiftAnd_4(i16 %a, i16 %b) {
+; CHECK-LABEL: testShiftAnd_4:
----------------
Is it intentional that all tests use the i16 type? Would it be beneficial/increase test coverage to include other common types like i32/i64?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69099/new/

https://reviews.llvm.org/D69099