[PATCH] D69087: [llvm-ar] Implement the O modifier: display member offsets inside the archive
Fangrui Song via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Oct 17 02:25:28 PDT 2019
MaskRay updated this revision to Diff 225381.
MaskRay marked 3 inline comments as done.
MaskRay added a comment.
Address review comments
1. (outs() << " 0x").write_hex(C.getDataOffset());
>
=
outs() << (" 0x" + utohexstr(C.getDataOffset(), true));
2. DisplayOffsets -> DisplayMemberOffsets
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D69087/new/
https://reviews.llvm.org/D69087
Files:
docs/CommandGuide/llvm-ar.rst
include/llvm/Object/Archive.h
test/Object/archive-thin-create.test
test/Object/archive-toc.test
tools/llvm-ar/llvm-ar.cpp
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D69087.225381.patch
Type: text/x-patch
Size: 5911 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20191017/d3ece82f/attachment.bin>
More information about the llvm-commits
mailing list