[PATCH] D69064: [ARM] Add dependency on GlobalISel for unit tests to fix shared libs build
Diana Picus via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Oct 17 01:57:02 PDT 2019
rovka added a comment.
Could you be a little more specific? I just ran a build with BUILD_SHARED_LIBS=ON and it seemed to work.
================
Comment at: unittests/CodeGen/CMakeLists.txt:12
Target
+ GlobalISel
)
----------------
Why is this necessary? There's a subdirectory for GlobalISel, if some unit test in here is pulling in GlobalISel it's worth investigating why.
================
Comment at: unittests/Target/ARM/CMakeLists.txt:15
Target
+ GlobalISel
)
----------------
Nit; These lists are sorted alphabetically.
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D69064/new/
https://reviews.llvm.org/D69064
More information about the llvm-commits
mailing list