[PATCH] D68128: [InstCombine] Fold PHIs with equal incoming pointers

Daniil Suchkov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 17 00:31:38 PDT 2019


DaniilSuchkov added inline comments.


================
Comment at: llvm/include/llvm/IR/Value.h:575-576
+  /// If \p IsInBounds is not a nullptr and at least one GEP is stripped,
+  /// IsInBounds will reflect whether the accumulated offset is inbounds or not,
+  /// otherwise the value won't be modified.
+  ///
----------------
lebedev.ri wrote:
> This could better out what happens when more than one GEP is stripped, and they had different inbound-ness.
You're right, that is a tricky question, I will provide details on the behavior in this case.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68128/new/

https://reviews.llvm.org/D68128





More information about the llvm-commits mailing list