[PATCH] D68341: [AIX] TOC pseudo expansion for 64bit large + 64bit small + 32bit large modes

Xiangling Liao via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 16 14:04:16 PDT 2019


Xiangling_L added a comment.

In D68341#1711822 <https://reviews.llvm.org/D68341#1711822>, @hubert.reinterpretcast wrote:

> LGTM. Thanks.


Thank you for your reviews.



================
Comment at: llvm/test/CodeGen/PowerPC/lower-globaladdr64-aix-asm.ll:15
+
+; SMALL-LABEL: .test_load{{$}}
+; SMALL: ld [[REG1:[0-9]+]], LC0(2)
----------------
hubert.reinterpretcast wrote:
> Does this pass without a colon? Check also for the cases below.
Thanks for mentioning this, it happended to pass because it matched `.test_load` in function descriptor. I will update it to function entry point label.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68341/new/

https://reviews.llvm.org/D68341





More information about the llvm-commits mailing list