[PATCH] D69018: [AArch64] Fix offset calculation

[Sander de Smalen via Phabricator via llvm-commits]

sdesmalen accepted this revision.
sdesmalen added a comment.
This revision is now accepted and ready to land.

In D69018#1711613 <https://reviews.llvm.org/D69018#1711613>, @smeenai wrote:

> @sdesmalen How does the new test case look?


Thanks, the new test-case seems to cover the case well. It is out of range of the immediate and with NewOffset as `int64_t` the expression `NewOffset * Scale` should no longer be evaluated as `unsigned`.

LGTM



================
Comment at: llvm/test/CodeGen/AArch64/framelayout-large-offset.mir:3
+---
+name: framelayout_large_offset
+tracksRegLiveness: true
----------------
nit: You'll want to change the name of the test/function now.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69018/new/

https://reviews.llvm.org/D69018