[PATCH] D68426: [gicombiner] Hoist pure C++ combine into the tablegen definition

[Volkan Keles via Phabricator via llvm-commits]

volkan added inline comments.


================
Comment at: llvm/utils/TableGen/GICombinerEmitter.cpp:269
+
+    OS << Indent << "  if (1\n";
+
----------------
Rules must have a matcher, right? If so, why do we need `1 &&` here? 


================
Comment at: llvm/utils/TableGen/GICombinerEmitter.cpp:282
+         << Indent << "      "
+         << CodeExpander(Rule->getCode()->getValue(), Expansions,
+                         Rule->getCode()->getLoc(), ShowExpansions)
----------------
Don't we need to get the Matcher here as we do that for Applyer below?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68426/new/

https://reviews.llvm.org/D68426