[PATCH] D69068: [codeview] Workaround for PR43479, don't re-emit instr labels

Reid Kleckner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 16 13:18:40 PDT 2019


rnk created this revision.
rnk added a reviewer: akhuang.
Herald added subscribers: hiraditya, aprantl.
Herald added a project: LLVM.

In the long run we should come up with another mechanism for marking
call instructions as heap allocation sites, and remove this workaround.
For now, we've had two bug reports about this, so let's apply this
workaround. SLH (the other client of instruction labels) probably has
the same bug, but the solution there is more likely to be to mark the
call instruction as not duplicatable, which doesn't work for debug info.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D69068

Files:
  llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp
  llvm/test/CodeGen/X86/taildup-heapallocsite.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D69068.225299.patch
Type: text/x-patch
Size: 5218 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20191016/73169121/attachment.bin>


More information about the llvm-commits mailing list