[PATCH] D68628: GlobalISel: Implement lower for G_SADDO/G_SSUBO

Volkan Keles via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 16 12:59:54 PDT 2019


volkan accepted this revision.
volkan added a comment.
This revision is now accepted and ready to land.

LGTM.



================
Comment at: test/CodeGen/AMDGPU/GlobalISel/legalize-saddo.mir:39
+    %3:_(s16) = G_TRUNC %1
+
+    %4:_(s16), %5:_(s1) = G_SADDO %2, %3
----------------
Nit: empty line


================
Comment at: test/CodeGen/AMDGPU/GlobalISel/legalize-ssubo.mir:39
+    %3:_(s16) = G_TRUNC %1
+
+    %4:_(s16), %5:_(s1) = G_SSUBO %2, %3
----------------
Same here


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68628/new/

https://reviews.llvm.org/D68628





More information about the llvm-commits mailing list