[PATCH] D67948: [LV] Interleaving should not exceed estimated loop trip count.

[Hideki Saito via Phabricator via llvm-commits]

hsaito added inline comments.


================
Comment at: llvm/lib/Transforms/Vectorize/LoopVectorize.cpp:5265-5266
 
   // If the trip count is constant, limit the interleave count to be less than
   // the trip count divided by VF.
+  if (BestKnownTC) {
----------------
ebrevnov wrote:
> hsaito wrote:
> > If trip count is expected to be small, limit the interleave count to be less than the trip count divided by VF
> There is some ambiguity in using "small" through out the code. For getSmallBestKnownTC  "small" is if it fits 32-bit. For "if (BestKnownTC && *BestKnownTC < TinyTripCountInterleaveThreshold)" check "small" is what less than TinyTripCountInterleaveThreshold. Here "small" should refer to the meaning defined by getSmallBestKnownTC .
> I think we better avoid using "small" one more time here to minimize the confusion.
Sorry for being unclear. I was suggesting an update to the comment. With this patch, BestKnownTC is not constant, right?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67948/new/

https://reviews.llvm.org/D67948