[PATCH] D69018: [AArch64] Fix offset calculation

Shoaib Meenai via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 16 09:41:24 PDT 2019


smeenai marked an inline comment as done.
smeenai added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64InstrInfo.cpp:3442
   if (EmittableOffset)
     *EmittableOffset = NewOffset;
   if (OutUseUnscaledOp)
----------------
sdesmalen wrote:
> smeenai wrote:
> > EmittableOffset is still an int ... idk if I should be promoting that too.
> That should be fine, because it will be used for the immediate field of an instruction.
I decided to change it to `int64_t` as well, since the only call site which uses this parameter passes it to `MachineOperand::ChangeToImmediate`, which takes an `int64_t` parameter.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69018/new/

https://reviews.llvm.org/D69018





More information about the llvm-commits mailing list