[PATCH] D68959: [lld][WebAssebmly] Preserve custom import attributes with LTO
    Sam Clegg via Phabricator via llvm-commits 
    llvm-commits at lists.llvm.org
       
    Wed Oct 16 08:09:00 PDT 2019
    
    
  
sbc100 marked an inline comment as done.
sbc100 added inline comments.
================
Comment at: lld/wasm/Driver.cpp:581
+// Called by addWrappedSymbols as part of the handling of -wrap arguments
+static Symbol *addUndefinedWrapSymbol(Symbol* target, StringRef name) {
+  StringRef importModule = defaultModule;
----------------
ruiu wrote:
> Is this code tested? (i.e. is there any test that will fail if we undo this change?)
Hmmm,  you are right, this change was needed as part of an earlier version of this change.  Reverting it works fine.
Repository:
  rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68959/new/
https://reviews.llvm.org/D68959
    
    
More information about the llvm-commits
mailing list