[PATCH] D68337: [ARM][MVE] Enable extending masked loads
Sam Parker via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Oct 16 02:43:38 PDT 2019
samparker marked an inline comment as done.
samparker added inline comments.
================
Comment at: lib/Target/ARM/ARMTargetTransformInfo.cpp:499
+ // TODO: Support unaligned accesses?
+ if (!Alignment.hasValue())
+ return false;
----------------
dmgreen wrote:
> How rare do you think loads with no explicit alignment to be? I think they don't come up from clang, but is it worth leaving them till later?
>
> As far as I understand, if the alignment on the load was missing (value is 0), it is treated as the abi/pref alignment from the datalayout. So will have an alignment of 8 or 16, so will be aligned.
ok.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D68337/new/
https://reviews.llvm.org/D68337
More information about the llvm-commits
mailing list