[PATCH] D68783: [AArch64] Fix access to uninitialized CalleeSavedStackSize

Muhammad Omair Javaid via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 16 00:35:15 PDT 2019


omjavaid added a comment.

In D68783#1709000 <https://reviews.llvm.org/D68783#1709000>, @sdesmalen wrote:

> In D68783#1708963 <https://reviews.llvm.org/D68783#1708963>, @omjavaid wrote:
>
> > This revision does not fix LLDB regression on AArch64.
> >
> > http://lab.llvm.org:8014/builders/lldb-aarch64-ubuntu
> >
> > All tests in functionalities/thread/concurrent_events/* category still failing.
>
>
> Correct, those tests are fixed by D66935 <https://reviews.llvm.org/D66935>. That fix was reverted because of a failure with `msan` on `test/DebugInfo/AArch64/asan-stack-vars.mir` and `test/DebugInfo/AArch64/compiler-gen-bbs-livedebugvalues.mir`, which this patch intends to fix. I kept the fixes separate to make them easier to review. Do you want me to merge the two patches?


Yes, I guess it will be the right idea to merge both patches otherwise you might see failing buildbots when both patches get merged at different times.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68783/new/

https://reviews.llvm.org/D68783





More information about the llvm-commits mailing list