[PATCH] D69018: [AArch64] Fix offset calculation

Shoaib Meenai via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 15 22:37:01 PDT 2019


smeenai marked an inline comment as done.
smeenai added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64InstrInfo.cpp:3438
     NewOffset = NewOffset < 0 ? MinOff : MaxOff;
     Offset = Offset - NewOffset * Scale + Remainder;
   }
----------------
Just casting NewOffset to int64_t over here is actually sufficient, but I figured changing the type entirely was better/cleaner.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69018/new/

https://reviews.llvm.org/D69018





More information about the llvm-commits mailing list