[PATCH] D68959: [lld][WebAssebmly] Preserve custom import attributes with LTO

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added inline comments.


================
Comment at: lld/wasm/Driver.cpp:581
+// Called by addWrappedSymbols as part of the handling of -wrap arguments
+static Symbol *addUndefinedWrapSymbol(Symbol* target, StringRef name) {
+  StringRef importModule = defaultModule;
----------------
Is this code tested? (i.e. is there any test that will fail if we undo this change?)


================
Comment at: lld/wasm/SymbolTable.cpp:457
     }
+    auto* existingUndefined = dyn_cast<UndefinedFunction>(existingFunction);
     if (!existingFunction->signature && sig)
----------------
nit: `auto* ` -> `auto *`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68959/new/

https://reviews.llvm.org/D68959