[PATCH] D68664: [lit] Clean up internal diff's encoding handling

[Joel E. Denny via Phabricator via llvm-commits]

jdenny updated this revision to Diff 225137.
jdenny edited the summary of this revision.
jdenny added a comment.

Rebased onto master so it doesn't depend on D66574 <https://reviews.llvm.org/D66574> anymore. Thus, it modifies TestRunner.py instead of diff.py.

Added `lit.util.to_string` calls to transform diff output before writing to stdout.  I built in a local Windows 10 to test this.  With Python 2.7 and without `to_string`, I was able to reproduce at least some of the previous bot failures, and `to_string` fixes them.  I also tried Python 3.6, and it works fine for me.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68664/new/

https://reviews.llvm.org/D68664

Files:
  llvm/utils/lit/lit/TestRunner.py
  llvm/utils/lit/tests/Inputs/shtest-shell/diff-encodings.txt
  llvm/utils/lit/tests/Inputs/shtest-shell/diff-in.bin
  llvm/utils/lit/tests/Inputs/shtest-shell/diff-in.utf16
  llvm/utils/lit/tests/Inputs/shtest-shell/diff-in.utf8
  llvm/utils/lit/tests/max-failures.py
  llvm/utils/lit/tests/shtest-shell.py

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D68664.225137.patch
Type: text/x-patch
Size: 6922 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20191016/11c8ef22/attachment.bin>