[PATCH] D68964: cmake/modules/CheckAtomic.cmake: catch false positives in RISC-V

Gokturk Yuksek via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 15 13:46:41 PDT 2019


gokturk added a comment.

In D68964#1710041 <https://reviews.llvm.org/D68964#1710041>, @gokturk wrote:

> I think we have potentially 3 separate bugs:
>
> 1. In LLVM, the check for libatomic has false positives in RISC-V (which the patch is addressing).
> 2. In LLVM, the result of the libatomic check is not being used to add '-latomic' to LDFLAGS.


See: https://reviews.llvm.org/D69003

I'm not sure if this was the right location for it. Let me know if you want it fixed differently.

> 3. libcxx libatomic check is likely to exhibit false positive in RISC-V.




Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68964/new/

https://reviews.llvm.org/D68964





More information about the llvm-commits mailing list