[PATCH] D69001: [NFC][XCOFF][AIX] Rename ControlSections to CsectGroup

[Jason Liu via Phabricator via llvm-commits]

jasonliu created this revision.
jasonliu added reviewers: sfertile, hubert.reinterpretcast, DiggerLin, daltenty.
Herald added subscribers: llvm-commits, hiraditya.
Herald added a project: LLVM.

The name of ControlSections is not expressive enough to convey what they really are. CsectGroup can better communicate the concept of grouping csects together since they have similar property.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D69001

Files:
  llvm/lib/MC/XCOFFObjectWriter.cpp


Index: llvm/lib/MC/XCOFFObjectWriter.cpp
===================================================================
--- llvm/lib/MC/XCOFFObjectWriter.cpp
+++ llvm/lib/MC/XCOFFObjectWriter.cpp
@@ -115,7 +115,7 @@
   // (approximately) the same storage mapping class. For example all the csects
   // with a storage mapping class of `xmc_pr` will get placed into the same
   // container.
-  using ControlSections = std::deque<ControlSection>;
+  using CsectGroup = std::deque<ControlSection>;
 
   support::endian::Writer W;
   std::unique_ptr<MCXCOFFObjectTargetWriter> TargetObjectWriter;
@@ -129,11 +129,11 @@
   Section Text;
   Section BSS;
 
-  // ControlSections. These store the csects which make up different parts of
+  // CsectGroups. These store the csects which make up different parts of
   // the sections. Should have one for each set of csects that get mapped into
   // the same section and get handled in a 'similar' way.
-  ControlSections ProgramCodeCsects;
-  ControlSections BSSCsects;
+  CsectGroup ProgramCodeCsects;
+  CsectGroup BSSCsects;
 
   uint32_t SymbolTableEntryCount = 0;
   uint32_t SymbolTableOffset = 0;


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D69001.225089.patch
Type: text/x-patch
Size: 1135 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20191015/5663518d/attachment.bin>