[PATCH] D68620: DebugInfo: Use base address selection entries for debug_loc

[Stella Stamenova via Phabricator via llvm-commits]

stella.stamenova added a comment.

I haven't fully debugged this, but it looks like this change caused a failure on the Windows LLDB bot. There was already another failure, so you probably didn't get an email:

http://lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/9772

The Buildbot is still failing because of this test: http://lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/9884/steps/test/logs/stdio

When running the test locally, the output is:

  (lldb) file E:\_work\22\b\tools\lldb\lldb-test-build.noindex\lang\c\local_variables\TestLocalVariables.test_c_local_variables_dwarf\a.out
  Current executable set to 'E:\_work\22\b\tools\lldb\lldb-test-build.noindex\lang\c\local_variables\TestLocalVariables.test_c_local_variables_dwarf\a.out' (x86_64).
  (lldb) br s -f main.c -l 13
  Breakpoint 1: where = a.out`foo + 9 at main.c:13:3, address = 0x0000000140001029
  (lldb) r
  Process 43368 launched: 'E:\_work\22\b\tools\lldb\lldb-test-build.noindex\lang\c\local_variables\TestLocalVariables.test_c_local_variables_dwarf\a.out' (x86_64)
  Process 43368 stopped
  * thread #1, stop reason = breakpoint 1.1
      frame #0: 0x00007ff6a0141029 a.out`foo(j=<unavailable>) at main.c:13:3
     10     unsigned i = j;
     11     bar(i);
     12     i = 10;
  -> 13     bar(i); // Set break point at this line.
     14   }
     15
     16   int main(int argc, char** argv)
  (lldb) thread list
  Process 43368 stopped
  * thread #1: tid = 0x9a78, 0x00007ff6a0141029 a.out`foo(j=<unavailable>) at main.c:13:3, stop reason = breakpoint 1.1
  (lldb) breakpoint list -f
  Current breakpoints:
  1: file = 'main.c', line = 13, exact_match = 0, locations = 1, resolved = 1, hit count = 1
    1.1: where = a.out`foo + 9 at main.c:13:3, address = 0x00007ff6a0141029, resolved, hit count = 1
  
  (lldb) frame variable i
  (unsigned int) i = <variable not available>


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68620/new/

https://reviews.llvm.org/D68620