[lld] r374891 - [lld] Check for branch range overflows.

[Sid Manning via llvm-commits]

Author: sidneym
Date: Tue Oct 15 07:12:54 2019
New Revision: 374891

URL: http://llvm.org/viewvc/llvm-project?rev=374891&view=rev
Log:
[lld] Check for branch range overflows.

Differential Revision: https://reviews.llvm.org/D68875

Added:
    lld/trunk/test/ELF/hexagon-jump-error.s
Modified:
    lld/trunk/ELF/Arch/Hexagon.cpp

Modified: lld/trunk/ELF/Arch/Hexagon.cpp
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/Arch/Hexagon.cpp?rev=374891&r1=374890&r2=374891&view=diff
==============================================================================
--- lld/trunk/ELF/Arch/Hexagon.cpp (original)
+++ lld/trunk/ELF/Arch/Hexagon.cpp Tue Oct 15 07:12:54 2019
@@ -242,15 +242,18 @@ void Hexagon::relocateOne(uint8_t *loc,
     or32le(loc, applyMask(0x0fff3fff, val >> 6));
     break;
   case R_HEX_B9_PCREL:
+    checkInt(loc, val, 11, type);
     or32le(loc, applyMask(0x003000fe, val >> 2));
     break;
   case R_HEX_B9_PCREL_X:
     or32le(loc, applyMask(0x003000fe, val & 0x3f));
     break;
   case R_HEX_B13_PCREL:
+    checkInt(loc, val, 15, type);
     or32le(loc, applyMask(0x00202ffe, val >> 2));
     break;
   case R_HEX_B15_PCREL:
+    checkInt(loc, val, 17, type);
     or32le(loc, applyMask(0x00df20fe, val >> 2));
     break;
   case R_HEX_B15_PCREL_X:
@@ -258,6 +261,7 @@ void Hexagon::relocateOne(uint8_t *loc,
     break;
   case R_HEX_B22_PCREL:
   case R_HEX_PLT_B22_PCREL:
+    checkInt(loc, val, 22, type);
     or32le(loc, applyMask(0x1ff3ffe, val >> 2));
     break;
   case R_HEX_B22_PCREL_X:

Added: lld/trunk/test/ELF/hexagon-jump-error.s
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/test/ELF/hexagon-jump-error.s?rev=374891&view=auto
==============================================================================
--- lld/trunk/test/ELF/hexagon-jump-error.s (added)
+++ lld/trunk/test/ELF/hexagon-jump-error.s Tue Oct 15 07:12:54 2019
@@ -0,0 +1,31 @@
+# REQUIRES: hexagon
+# RUN: llvm-mc -filetype=obj -triple=hexagon-unknown-elf %s -o %t.o
+# RUN: not ld.lld %t.o -o %t 2>&1 | FileCheck --implicit-check-not "out of range" %s
+
+	.globl	_start
+	.type	_start, @function
+_start:
+
+# CHECK: relocation R_HEX_B9_PCREL out of range: 1028 is not in [-1024, 1023]
+{r0 = #0; jump #1f}
+.space (1<<10)
+.section b9, "ax"
+1:
+
+# CHECK-NEXT: relocation R_HEX_B13_PCREL out of range: 16388 is not in [-16384, 16383]
+if (r0==#0) jump:t #1f
+.space (1<<14)
+.section b13, "ax"
+1:
+
+# CHECK-NEXT: relocation R_HEX_B15_PCREL out of range: 65540 is not in [-65536, 65535]
+if (p0) jump #1f
+.space (1<<16)
+.section b15, "ax"
+1:
+
+# CHECK-NEXT: relocation R_HEX_B22_PCREL out of range: 8388612 is not in [-2097152, 2097151]
+jump #1f
+.space (1<<23)
+.section b22, "ax"
+1: