[PATCH] D68943: [llvm][yaml2obj] no more implicit ELF .symtab section

Konrad Wilhelm Kleine via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 15 04:55:31 PDT 2019


kwk added a comment.

I noticed that the order of sections does matter to some tests. Before the `.symtab` section was always the first one and now it is the last of the implicit sections being created. Some `Link: X`  checks break because `X` points to a different section. In order to compensate for this I will make `.symtab` the first of the implicit sections again. In my local testing this already helps a bit. In cases where we refer to a section by number and expect `.symtab` to be the section being referenced, I have two options: 1st) create a symbol to force `.symtab` to be implicitly created or 2nd) change the name of the expected section. Just tell me what you want.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68943/new/

https://reviews.llvm.org/D68943





More information about the llvm-commits mailing list