[PATCH] D68337: [ARM][MVE] Enable extending masked loads

[Sam Parker via Phabricator via llvm-commits]

samparker marked an inline comment as done.
samparker added a comment.

Thanks @craig.topper. I'll add the necessary changes into the X86 backend.



================
Comment at: llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp:9324
+                                      Ld->getMemOperand(), ExtLoadType,
+                                      Ld->isExpandingLoad());
+  DAG.ReplaceAllUsesOfValueWith(SDValue(N, 0), SDValue(NewLoad.getNode(), 0));
----------------
craig.topper wrote:
> Should we disable this if the load is an expanding load? X86 supports expanding loads, but not extending expanding loads. Or is the expectation that I should block that in X86's implementation of isVectorLoadExtDesirable?
Good point... I think it makes sense for this part to be as generic as possible and leave it to the backends. We'll have to do the same too.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68337/new/

https://reviews.llvm.org/D68337