[PATCH] D68925: [Attributor] Liveness for values

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert marked 2 inline comments as done.
jdoerfert added inline comments.


================
Comment at: llvm/lib/Transforms/IPO/Attributor.cpp:3641
       return Changed;
+    Value &V = getAssociatedValue();
+    if (isa<Constant>(V))
----------------
sstefan1 wrote:
> Should this still be here, considering changes from D68934?
I think D68934 replaces all this, I will undo this change here.


================
Comment at: llvm/lib/Transforms/IPO/Attributor.cpp:4519
+  const IRPosition &IRP = QueryingAA.getIRPosition();
+  const Value &AssociatedValue = IRP.getAssociatedValue();
+  SmallVector<const Use *, 16> Worklist;
----------------
sstefan1 wrote:
> Can we have a value parameter here that maybe defaults to nullptr. In the default case we take `AssociatedValue` and in others the value parameter? Maybe this is not the best solution, but for example, h2s doesn't work with `AssociatedValue`.
Sure, we don't even need a default. Though we can also do this after the patch. I'll change the interface now here though.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68925/new/

https://reviews.llvm.org/D68925