[PATCH] D68869: [DebugInfo] Fix truncation of call site immediates

David Stenberg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 14 05:47:24 PDT 2019


dstenb marked an inline comment as done.
dstenb added inline comments.


================
Comment at: llvm/lib/CodeGen/AsmPrinter/DwarfDebug.cpp:623
       if (ParamValue->first.isImm()) {
-        unsigned Val = ParamValue->first.getImm();
+        auto Val = ParamValue->first.getImm();
         DbgValueLoc DbgLocVal(ParamValue->second, Val);
----------------
aprantl wrote:
> We should only use auto where the type is obvious from the context. Let's use uint64_t here.
Oh, right! As both the return value from `getImm()` and the DbgValueLoc constructor's parameter are int64_t I went with that in favor of uint64_t.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68869/new/

https://reviews.llvm.org/D68869





More information about the llvm-commits mailing list