[PATCH] D68911: [AArch64] enable (v)select to math TLI hook (WIP)

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Oct 12 07:26:55 PDT 2019


spatel created this revision.
spatel added reviewers: greened, t.p.northover, sebpop, SjoerdMeijer, kristof.beyls.
Herald added subscribers: hiraditya, mcrosier.
Herald added a project: LLVM.

I added more select-to-shift folds to DAGCombiner in:
rL374397 <https://reviews.llvm.org/rL374397>
rL374555 <https://reviews.llvm.org/rL374555>
...and noticed that AArch64 does not override a TLI hook that was added with:
rL296977 <https://reviews.llvm.org/rL296977>

Not sure if that is intentional or oversight, so I flipped the setting completely and updated some auto-generated regression tests. It's not a universal win, but likely worth doing? If so, there are a few more regression tests that need updating/inspection.

I don't intend to do more with this patch, so feel free to commandeer/close.


https://reviews.llvm.org/D68911

Files:
  llvm/lib/Target/AArch64/AArch64ISelLowering.h
  llvm/test/CodeGen/AArch64/select_const.ll
  llvm/test/CodeGen/AArch64/selectcc-to-shiftand.ll
  llvm/test/CodeGen/AArch64/signbit-shift.ll
  llvm/test/CodeGen/AArch64/vselect-constants.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D68911.224741.patch
Type: text/x-patch
Size: 16060 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20191012/20ec177a/attachment.bin>


More information about the llvm-commits mailing list