[PATCH] D68836: [lit] Small cleanups in main.py

[Julian Lettner via Phabricator via llvm-commits]

yln marked an inline comment as done.
yln added inline comments.


================
Comment at: llvm/utils/lit/lit/main.py:32
+        import tempfile
         lit_tmp = tempfile.mkdtemp(prefix="lit_tmp_")
         os.environ.update({
----------------
rnk wrote:
> Unrelated, but I wonder if we should augment this logic to garbage collect old `lit_tmp_` directories that are 24+ hours old. I routinely find lots of leaked lit_tmp_ directories because oftentimes the parent Python process is killed before it gets to the finally block below.
One of the improvements for lit that I want to explore is graceful shutdown on `CTRL+C`.  If that isn't possible, we should implement your suggestion.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68836/new/

https://reviews.llvm.org/D68836