[PATCH] D67008: [llvm-readobj][XCOFF]implement parsing relocation information for 32-bit xcoff objectfile

[Digger via Phabricator via llvm-commits]

DiggerLin marked 2 inline comments as done.
DiggerLin added inline comments.


================
Comment at: llvm/lib/Object/XCOFFObjectFile.cpp:556
 }
+// In an XCOFF32 file, if more than 65,534 relocation entries are required,
+// the field value will be 65535, and an STYP_OVRFLO section header will
----------------
hubert.reinterpretcast wrote:
> hubert.reinterpretcast wrote:
> > DiggerLin wrote:
> > > hubert.reinterpretcast wrote:
> > > > We can reduce the amount of background for the comment to what is necessary to understand the code here:
> > > > In an XCOFF32 file, when the field value is 65535, then an STYP_OVRFLO section header contains the actual count of relocation entries in the s_paddr field. STYP_OVRFLO headers contain the section index of their corresponding sections as their raw "NumberOfRelocations" field value.
> > > added.
> > I am not seeing the change.
> Still not seeing the change: https://reviews.llvm.org/D67008?id=222237#inline-613037
changed the comment as  suggestion.


================
Comment at: llvm/lib/Object/XCOFFObjectFile.cpp:593
+                                      Sec.FileOffsetToRelocationInfo);
+  auto RelocEntNumOrErr = getLogicalNumberOfRelocationEntries(Sec);
+  if (Error E = RelocEntNumOrErr.takeError())
----------------
hubert.reinterpretcast wrote:
> hubert.reinterpretcast wrote:
> > Suggestion: `NumRelocEntriesOrErr`
> Still not seeing the change: https://reviews.llvm.org/D67008?id=222860#inline-616702
changed


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67008/new/

https://reviews.llvm.org/D67008