[PATCH] D67550: [AArch64][SVE] Implement unpack intrinsics

[Kerry McLaughlin via Phabricator via llvm-commits]

kmclaughlin marked 2 inline comments as done.
kmclaughlin added inline comments.


================
Comment at: lib/Target/AArch64/SVEInstrFormats.td:836
 class sve_int_perm_unpk<bits<2> sz16_64, bits<2> opc, string asm,
-                        ZPRRegOp zprty1, ZPRRegOp zprty2>
+                        ZPRRegOp zprty1, ZPRRegOp zprty2, SDPatternOperator op>
 : I<(outs zprty1:$Zd), (ins zprty2:$Zn),
----------------
greened wrote:
> Where is `op` used?  I assume that comes later but it would help to understand where this is going.
Thanks for pointing this out, op isn't actually used here!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67550/new/

https://reviews.llvm.org/D67550