[PATCH] D68338: [AMDGPU] Remove dubious logic in bidirectional list scheduler

Stanislav Mekhanoshin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 10 18:17:33 PDT 2019


rampitec added a comment.

In D68338#1703821 <https://reviews.llvm.org/D68338#1703821>, @foad wrote:

> Reviewers: any advice on handling lots of test updates like this? I could pre-commit some of the tests, where I've made them strictly more lenient. I could also add -enable-misched=false to any tests that aren't specifically testing the scheduler, update them and pre-commit that, in order to protect them from this and future scheduler tweaks.


I usually prefer to precommit non-essential test changes. It is less merges and smaller review.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68338/new/

https://reviews.llvm.org/D68338





More information about the llvm-commits mailing list