[PATCH] D68819: [Utils] Allow update_test_checks to check function arguments

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert added a comment.

In D68819#1704693 <https://reviews.llvm.org/D68819#1704693>, @greened wrote:

> Does this subsume the goal of D68153 <https://reviews.llvm.org/D68153>?  If so I am happy to abandon that revision.  D68153 <https://reviews.llvm.org/D68153> attempts to solve the problem of a `CHECK-LABEL` matching a function call instead of the start of a function definition.  It looks like with `--function-signature` the `CHECK-LABEL` will include the arguments in the label pattern which should be enough to disambiguate it from a call to the function.  Do I have that right?
>
> EDIT: Actually, I don't think it will completely work if there is a recursive call to, say, `foo` that passes the same arguments through.  In that case the call will look exactly like the function signature.  The same is true if an unrelated function makes a call to `foo` with values that just happen to be named the same as `foo`'s arguments.


We can, or should, combine D68153 <https://reviews.llvm.org/D68153> and this, either in one or two patches.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68819/new/

https://reviews.llvm.org/D68819