[PATCH] D67322: [LLD][ThinLTO] Handle GUID collision in import global processing

Teresa Johnson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 10 12:37:16 PDT 2019


tejohnson added a comment.

In D67322#1704278 <https://reviews.llvm.org/D67322#1704278>, @evgeny777 wrote:

> Is this the only place where bad things can happen? May be simply raise an error in `addGlobalValueSummary` when new summary type is different from that of `SummaryList[0]`?


We should probably have more testing of this situation. But if we can make it work we should wherever possible.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67322/new/

https://reviews.llvm.org/D67322





More information about the llvm-commits mailing list