[PATCH] D68816: [NFC] Replace a linked list in LiveDebugVariables pass with a DenseMap

[Adrian Prantl via Phabricator via llvm-commits]

aprantl added inline comments.


================
Comment at: llvm/lib/CodeGen/LiveDebugVariables.cpp:167
+    // FIXME: The fragment should be part of the identity, but not
+    // other things in the expression like stack values.
+    return Var == Variable && Expr == Expression && IA == InlinedAt;
----------------
Not your code, but: add a FragmentInfo element?


================
Comment at: llvm/lib/CodeGen/LiveDebugVariables.cpp:409
+  /// Map unique UserValue identity to UserValue.
+  using UVMap = DenseMap<UserValueIdentity, UserValue *>;
+  UVMap UserVarMap;
----------------
How many elements does this have on average? Is a SmallDenseMap a win?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68816/new/

https://reviews.llvm.org/D68816