[PATCH] D67986: [InstCombine] snprintf (d, size, "%s", s) -> memccpy (d, s, '\0', size - 1), d[size - 1] = 0

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert added a comment.

In D67986#1703031 <https://reviews.llvm.org/D67986#1703031>, @xbolva00 wrote:

> In D67986#1702901 <https://reviews.llvm.org/D67986#1702901>, @MaskRay wrote:
>
> > This transformation seems to increase code size significantly. Is the snprintf "%s" pattern common enough? I suspect most projects have already used memccpy, stpncpy, strscpy, or strlcpy. For the few that don't, the performance probably does not matter.
>
>
> Yes, quite common. But okay, if you dont want it, let's just abandon it.


I wouldn't have quit on this so easily, but OK.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67986/new/

https://reviews.llvm.org/D67986