[PATCH] D68632: [X86] Make memcmp() use PTEST if possible and also enable AVX1

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: lib/Target/X86/X86ISelLowering.cpp:42430
+      auto BCCmp = DAG.getBitcast(OpSize == 256 ? MVT::v4i64 : MVT::v2i64, Cmp);
+      auto PT = DAG.getNode(X86ISD::PTEST, DL, MVT::i32, BCCmp, BCCmp);
+      auto SetCC = getSETCC(CC == ISD::SETEQ ? X86::COND_E : X86::COND_NE, PT, DL, DAG);
----------------
You already used PT as a variable name earlier. The earlier one should probably be UsePTEST


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68632/new/

https://reviews.llvm.org/D68632