[PATCH] D68744: [GSYM] Add GsymCreator and GsymReader.

Thu Oct 10 08:59:20 PDT 2019

clayborg marked 9 inline comments as done.
clayborg added inline comments.

================
Comment at: lib/DebugInfo/GSYM/GsymCreator.cpp:197
+      if (Prev->Range.intersects(Curr->Range)) {
+        // Overlapping address ranges.
+        if (Prev->Range == Curr->Range) {
----------------
Not really because of the trickyness of erasing values form the Funcs. Note the "Curr = Funcs.erase(Prev);" statements in here. It is also why the while loop containing this can't be a simple for loop. I tried playing with this a bit and it stayed complicated, so left as is for now. Let me know if you still have objections.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68744/new/

https://reviews.llvm.org/D68744