[PATCH] D68656: Add ExceptionStream to llvm::Object::minidump

Joseph Tremoulet via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 10 08:31:08 PDT 2019


JosephTremoulet added a comment.

In D68656#1703711 <https://reviews.llvm.org/D68656#1703711>, @labath wrote:

> Hmm.. maybe just keep those constants defined in lldb somewhere (e.g. right next to or inside the `RefreshStateAfterStop` function)? That's the place which does the decoding and also includes the OS switch, so it makes it easier to explain their purpose and why they are different for each OS...


That works for me.  Updated.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68656/new/

https://reviews.llvm.org/D68656





More information about the llvm-commits mailing list