[lld] r374362 - [LLD][ELF] Fix stale comments about doing ICF

Russell Gallop via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 10 07:50:03 PDT 2019


Author: russell_gallop
Date: Thu Oct 10 07:50:02 2019
New Revision: 374362

URL: http://llvm.org/viewvc/llvm-project?rev=374362&view=rev
Log:
[LLD][ELF] Fix stale comments about doing ICF

Differential Revision: https://reviews.llvm.org/D68396

Modified:
    lld/trunk/ELF/Driver.cpp

Modified: lld/trunk/ELF/Driver.cpp
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/Driver.cpp?rev=374362&r1=374361&r2=374362&view=diff
==============================================================================
--- lld/trunk/ELF/Driver.cpp (original)
+++ lld/trunk/ELF/Driver.cpp Thu Oct 10 07:50:02 2019
@@ -1915,9 +1915,10 @@ template <class ELFT> void LinkerDriver:
   // Replace common symbols with regular symbols.
   replaceCommonSymbols();
 
-  // Do size optimizations: garbage collection, merging of SHF_MERGE sections
-  // and identical code folding.
+  // Split SHF_MERGE and .eh_frame sections into pieces in preparation for garbage collection.
   splitSections<ELFT>();
+
+  // Garbage collection and removal of shared symbols from unused shared objects.
   markLive<ELFT>();
   demoteSharedSymbols();
 




More information about the llvm-commits mailing list