[llvm] r374349 - Revert "[test] Use system locale for mri-utf8.test"

Thomas Preud'homme via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 10 06:39:12 PDT 2019


Author: thopre
Date: Thu Oct 10 06:39:12 2019
New Revision: 374349

URL: http://llvm.org/viewvc/llvm-project?rev=374349&view=rev
Log:
Revert "[test] Use system locale for mri-utf8.test"

This reverts commit r374318 / b6f1d1fa0e3ee0e25f22414bf97c05276b934507.

Added:
    llvm/trunk/test/tools/llvm-ar/mri-utf8.test
Removed:
    llvm/trunk/test/tools/llvm-ar/mri-nonascii.test

Removed: llvm/trunk/test/tools/llvm-ar/mri-nonascii.test
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/tools/llvm-ar/mri-nonascii.test?rev=374348&view=auto
==============================================================================
--- llvm/trunk/test/tools/llvm-ar/mri-nonascii.test (original)
+++ llvm/trunk/test/tools/llvm-ar/mri-nonascii.test (removed)
@@ -1,22 +0,0 @@
-# Test non-ascii archive members
-# XFAIL: system-darwin
-
-RUN: rm -rf %t && mkdir -p %t/extracted
-
-# Note: lit's Python will read this UTF-8 encoded mri-nonascii.txt file,
-# decode it to unicode. The filename in the redirection below will then
-# be encoded in the system's filename encoding (e.g. UTF-16 for
-# Microsoft Windows).
-RUN: echo "contents" > %t/£.txt
-
-RUN: echo "CREATE %t/mri.ar" > %t/script.mri
-RUN: echo "ADDMOD %t/£.txt" >> %t/script.mri
-RUN: echo "SAVE" >> %t/script.mri
-
-RUN: llvm-ar -M < %t/script.mri
-RUN: cd %t/extracted && llvm-ar x %t/mri.ar
-
-# Same as above.
-RUN: FileCheck --strict-whitespace %s <£.txt
-CHECK:{{^}}
-CHECK-SAME:{{^}}contents{{$}}

Added: llvm/trunk/test/tools/llvm-ar/mri-utf8.test
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/tools/llvm-ar/mri-utf8.test?rev=374349&view=auto
==============================================================================
--- llvm/trunk/test/tools/llvm-ar/mri-utf8.test (added)
+++ llvm/trunk/test/tools/llvm-ar/mri-utf8.test Thu Oct 10 06:39:12 2019
@@ -0,0 +1,23 @@
+# Test non-ascii archive members
+# XFAIL: system-darwin
+
+RUN: rm -rf %t && mkdir -p %t/extracted
+
+RUN: echo "contents" > %t/£.txt
+
+RUN: echo "CREATE %t/mri.ar" > %t/script.mri
+RUN: echo "ADDMOD %t/£.txt" >> %t/script.mri
+RUN: echo "SAVE" >> %t/script.mri
+
+RUN: llvm-ar -M < %t/script.mri
+RUN: cd %t/extracted && llvm-ar x %t/mri.ar
+
+# This works around problems launching processess that
+# include arguments with non-ascii characters.
+# Python on Linux defaults to ASCII encoding unless the
+# environment specifies otherwise, so it is explicitly set.
+# The reliance the test has on this locale is not ideal,
+# however alternate solutions have been difficult due to 
+# behaviour differences with python 2 vs python 3,
+# and linux vs windows.
+RUN: env LANG=en_US.UTF-8 %python -c "assert open(u'\U000000A3.txt', 'rb').read() == b'contents\n'"




More information about the llvm-commits mailing list