[PATCH] D68033: [llvm-ar] Make paths case insensitive when on windows

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 10 04:47:00 PDT 2019


MaskRay added a comment.

Case insensitivity and platform differences do make me sad, but if people think it is the right thing to do on Windows I'll not insist.

Note, GNU ar uses POSIX/C locale case matching. If we want to use `CompareStringOrdinal`, we should probably create an issue on https://sourceware.org/bugzilla

  #if defined (HAVE_CASE_INSENSITIVE_FILE_SYSTEM)
        c1 = TOLOWER (c1);
        c2 = TOLOWER (c2);
  #endif


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68033/new/

https://reviews.llvm.org/D68033





More information about the llvm-commits mailing list