[PATCH] D68780: [llvm-exegesis] Show noise cluster in analysis output.

Clement Courbet via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 10 04:44:19 PDT 2019


courbet marked an inline comment as done.
courbet added inline comments.


================
Comment at: llvm/tools/llvm-exegesis/lib/Analysis.cpp:593
+  printClusterRawHtml(InstructionBenchmarkClustering::ClusterId::noise(),
+                      "[noise]", OS);
+
----------------
gchatelet wrote:
> Can we call it "outliers" or "unattributed"? noise is a bit vague to me.
"Noise" is the classical [[ https://en.wikipedia.org/wiki/DBSCAN | dbscan ]] terminology, that has already been used in the Clustering class.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68780/new/

https://reviews.llvm.org/D68780





More information about the llvm-commits mailing list