[LNT] r374302 - [LNT] Python 3 support: remove useless var-setting getter

Thomas Preud'homme via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 10 03:29:02 PDT 2019


Author: thopre
Date: Thu Oct 10 03:29:01 2019
New Revision: 374302

URL: http://llvm.org/viewvc/llvm-project?rev=374302&view=rev
Log:
[LNT] Python 3 support: remove useless var-setting getter

Both the ComparisonResult constructor and the stddev_mean getter set
the readonly stddev_mean. While Python 2 accepts it, Python 3 throws
errors (cannot set attribute and infinite recursion respectively). Since
that attribute does not appear to be used anywhere, this commit removes
all this code.

Reviewers: cmatthews, hubert.reinterpretcast, kristof.beyls

Reviewed By: hubert.reinterpretcast

Subscribers: llvm-commits

Differential Revision: https://reviews.llvm.org/D67882

Modified:
    lnt/trunk/lnt/server/reporting/analysis.py

Modified: lnt/trunk/lnt/server/reporting/analysis.py
URL: http://llvm.org/viewvc/llvm-project/lnt/trunk/lnt/server/reporting/analysis.py?rev=374302&r1=374301&r2=374302&view=diff
==============================================================================
--- lnt/trunk/lnt/server/reporting/analysis.py (original)
+++ lnt/trunk/lnt/server/reporting/analysis.py Thu Oct 10 03:29:01 2019
@@ -96,7 +96,6 @@ class ComparisonResult:
             self.stddev = None
             self.MAD = None
 
-        self.stddev_mean = None  # Only calculate this if needed.
         self.failed = cur_failed
         self.prev_failed = prev_failed
         self.samples = samples
@@ -105,14 +104,6 @@ class ComparisonResult:
         self.confidence_lv = confidence_lv
         self.bigger_is_better = bigger_is_better
 
-    @property
-    def stddev_mean(self):
-        """The mean around stddev for current sampples. Cached after first call.
-        """
-        if not self.stddev_mean:
-            self.stddev_mean = stats.mean(self.samples)
-        return self.stddev_mean
-
     def __repr__(self):
         """Print this ComparisonResult's constructor.
 




More information about the llvm-commits mailing list