[PATCH] D68769: Revert "[AMDGPU] Run `unreachable-mbb-elimination` after isel to clean up PHIs."

Jay Foad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 10 02:22:22 PDT 2019


foad created this revision.
foad added reviewers: hliao, arsenm, tpr, dstuttard.
Herald added subscribers: hiraditya, t-tye, yaxunl, nhaehnle, wdng, jvesely, kzhuravl.
Herald added a project: LLVM.

This has been superseded by "[AMDGPU]: PHI Elimination hooks added for custom COPY insertion."

This reverts the code changes from commit 53f967f2bdb6aa7b08596880c3689d1ecad6f0ff <https://reviews.llvm.org/rG53f967f2bdb6aa7b08596880c3689d1ecad6f0ff>
but keeps the test case.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D68769

Files:
  llvm/lib/Target/AMDGPU/AMDGPUTargetMachine.cpp


Index: llvm/lib/Target/AMDGPU/AMDGPUTargetMachine.cpp
===================================================================
--- llvm/lib/Target/AMDGPU/AMDGPUTargetMachine.cpp
+++ llvm/lib/Target/AMDGPU/AMDGPUTargetMachine.cpp
@@ -885,9 +885,6 @@
   addPass(createSILowerI1CopiesPass());
   addPass(createSIFixupVectorISelPass());
   addPass(createSIAddIMGInitPass());
-  // FIXME: Remove this once the phi on CF_END is cleaned up by either removing
-  // LCSSA or other ways.
-  addPass(&UnreachableMachineBlockElimID);
   return false;
 }
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D68769.224284.patch
Type: text/x-patch
Size: 540 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20191010/91801077/attachment.bin>


More information about the llvm-commits mailing list